daroche/nginx-otel-nix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address review notices.

Browse source
This commit is contained in:
Eugene Grebenschikov 2024-12-19 13:48:54 -08:00
parent 348c6ae4dc
commit bef27d4815
2 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/test_otel.py
View file

@ -28,7 +28,6 @@ http {
}
otel_trace on;
{{ service_name }}
{{ res_attrs }}
server {
@ -272,9 +271,11 @@ def test_batches(client, trace_service, batch_count):
"nginx_config",
[
{
"service_name": 'otel_service_name "test_service";',
"res_attrs": 'otel_resource_attr my.name "my name";\n'
+ 'otel_resource_attr my.service "my service";',
"res_attrs": """
otel_service_name "test_service";
otel_resource_attr my.name "my name";
otel_resource_attr my.service "my service";
""",
}
],
indirect=True,
@ -282,12 +283,7 @@ def test_batches(client, trace_service, batch_count):
def test_custom_resource_attributes(client, trace_service):
assert client.get("http://127.0.0.1:18080/ok").status_code == 200
for _ in range(10):
if len(trace_service.batches):
break
time.sleep(0.001)
assert len(trace_service.batches) == 1
trace_service.wait_batch()
for batch in trace_service.batches:
assert get_attr(batch[0].resource, "service.name") == "test_service"