fixup! Address review notices.

This commit is contained in:
Eugene Grebenschikov 2024-12-19 13:50:43 -08:00
parent bef27d4815
commit e625db711a
2 changed files with 3 additions and 3 deletions

View file

@ -283,7 +283,7 @@ def test_batches(client, trace_service, batch_count):
def test_custom_resource_attributes(client, trace_service):
assert client.get("http://127.0.0.1:18080/ok").status_code == 200
trace_service.wait_batch()
trace_service.wait_one_batch()
for batch in trace_service.batches:
assert get_attr(batch[0].resource, "service.name") == "test_service"

View file

@ -14,7 +14,7 @@ class TraceService(trace_service_pb2_grpc.TraceServiceServicer):
self.batches.append(request.resource_spans)
return trace_service_pb2.ExportTracePartialSuccess()
def wait_batch(self):
def wait_one_batch(self):
for _ in range(10):
if len(self.batches):
break
@ -22,7 +22,7 @@ class TraceService(trace_service_pb2_grpc.TraceServiceServicer):
assert len(self.batches) == 1, "No spans received"
def get_span(self):
self.wait_batch()
self.wait_one_batch()
span = self.batches[0][0].scope_spans[0].spans.pop()
self.batches.clear()
return span